Repository navigation
Conversation
Author
|
closing this since it hasn't been picked up, happy to reopen if it's useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
verify_payment_link_signaturebuilds the signed payload usingattributes.values.join('|'), which makes verification depend on the insertion order of the caller's Hash.It also includes unrelated attributes in the payload and removes
:razorpay_signaturefrom the caller's Hash while verifying.As a result, the same valid Payment Link parameters can fail verification when supplied in a different order or alongside an unrelated field.
Fix
:razorpay_signaturewithout mutating the caller's Hash.Tests
Added regression coverage for:
Verification
test_generate_onboarding_signaturefailure remains from the current repository stateFixes #276