Repository navigation
Conversation
…ipart upload - Use .equals() instead of == for string comparison in getMediaType (== compares references, always false for string literals at runtime) - Fix MIME types: image/jpeg for images, application/pdf for PDFs (was image/jpg and image/pdf) - Add .toLowerCase() so extension matching is case-insensitive - Skip the "file" key in the form-data loop to prevent adding it twice (once as a proper file part, once as a plain string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getMediaTypeused==to compare strings (compares references, not values — alwaysfalseat runtime), so the image branch was never takenimage/jpg(invalid) instead ofimage/jpeg, and PDFs were returningimage/pdfinstead ofapplication/pdffilefield:fileRequestBodyadded the file both as a proper multipart file part and again as a plain string form-data part because the iterator loop didn't skip the"file"keyChanges
.equals()for string comparison ingetMediaType.toLowerCase()so extension matching is case-insensitiveimage/jpegfor images,application/pdffor PDFs"file"key in the form-data loop to prevent adding it twiceTest plan
.jpg/.jpeg/.png/.jfiffile — verifyContent-Typeisimage/jpeg.pdffile — verifyContent-Typeisapplication/pdffilefield appears exactly once (as a file part, not also as a string part)