Skip to content

Don't add a divider above the first Articles navbar heading - #3034

Open
schloerke wants to merge 1 commit into
r-lib:mainfrom
schloerke:schloerke/articles-first-divider
Open

schloerke wants to merge 1 commit into
r-lib:mainfrom
schloerke:schloerke/articles-first-divider

Conversation

@schloerke

Copy link
Copy Markdown

Fixes #3033. When the first articles: section has a navbar: heading, the Bootstrap 5 Articles menu started with an empty divider, as reported in #1319 for Bootstrap 4. navbar_articles() now adds the divider only before the second and later headings.

The navbar with label snapshot loses its leading '---------'. A new navbar with two labelled sections snapshot shows the divider is kept between sections.

I checked this on ellmer's site, where the empty divider pushed the last article past the menu's 280px max-height.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Articles dropdown starts with an empty divider (Bootstrap 5)

1 participant