Repository navigation
Conversation
…fall off the end Closes r-lib#33
schloerke
marked this pull request as ready for review
October 21, 2026 20:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33. An async function that ended with a loop or an
ifwithoutelsereturned the exhaustion sentinel instead of a promise, sopromises::then(async(function() while (FALSE) NULL)(), ~ NULL)failed. With anawait()before the loop, the promise resolved to the sentinel instead ofNULL. The cause was the fall-through return at the end of the state machine inwalk_states(), which always returnedexhausted(). A newfallthrough_value()helper now returnsas_promise(NULL)for async functions andas_promise(exhausted())for async generators.Async generators had a second gap: calling one again after it was done returned the raw sentinel, while the docs say it always returns a promise. The exhausted check in the generator instance now wraps the sentinel in a promise for async generators, except on
close = TRUE, which is only used for cleanup. Plain generators are unchanged.Tests were written first and failed before the fix. The parser and async snapshots change only the final fall-through line.
devtools::test()passes locally (317 pass, 2 skipped for reticulate).