Repository navigation
docs(release): document the agent gate hook and its env-var requirement - #27
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runbook documents both ways to approve the
productiongate, but never mentions thePreToolUsehook that enforces them — so a denied approval reads as a broken release rather thanas the safety property working. That is exactly how it presented while releasing 0.1.5: two
approval attempts were refused and nothing in the docs explained why.
Adds a "The agent gate hook" subsection to §5 recording the non-obvious part: the hook reads
REVCLI_GATE_APPROVEDfrom its own environment, inherited from the agent process, so thevariable is resolved before the shell exists. Setting it inline on the command, or exporting it
earlier in the same command, both still get denied. Only a variable present when the agent
launches lets the call through. The section keeps the existing steer that approving by hand in
the UI is the preferred path.
Docs-only. Verified locally on this branch:
npm run typecheckexit 0,npm test297 passed(17 files) exit 0,
npm run buildexit 0,npm run check:packexit 0. The repo has no markdownlinter, so nothing here validates the prose itself.
Reviewer note: this body deliberately does not quote the two command strings the new section
contains. The hook matches raw tool input, so a body quoting them is refused — which is part of
what the section documents.