Conversation
multiprocess is imported by tests/test_pe.py only (test_pe.py:21), to work around CPython's inability to pickle bound methods for the Windows PE test subprocesses. It was declared as a mandatory runtime dependency, so every `pip install qiling` shipped multiprocess and dill to users who never run the test suite. Declare it as a "test" extra rather than a Poetry dev group: CI installs the package with `pip3 install .`, and pip cannot see Poetry groups, so a group would silently break test_pe.bat on Windows. The extra keeps a single source of truth for the version constraint and needs only the Windows job to ask for it. No test changes: tests/test_pe.py is unchanged and is the test that proves the dependency is still delivered, via the CI job that now installs ".[test]". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
multiprocess is imported by tests/test_pe.py only (test_pe.py:21), to work around CPython's inability to pickle bound methods for the Windows PE test subprocesses. It was declared as a mandatory runtime dependency, so every
pip install qilingshipped multiprocess and dill to users who never run the test suite.Declare it as a "test" extra rather than a Poetry dev group: CI installs the package with
pip3 install ., and pip cannot see Poetry groups, so a group would silently break test_pe.bat on Windows. The extra keeps a single source of truth for the version constraint and needs only the Windows job to ask for it.No test changes: tests/test_pe.py is unchanged and is the test that proves the dependency is still delivered, via the CI job that now installs ".[test]".
Written by Claude, but validated and checked by me.