[cachetools] Fix TTLCache/TLRUCache constructor type inference - #16251
Open
ekanshul wants to merge 1 commit into
Open
[cachetools] Fix TTLCache/TLRUCache constructor type inference#16251ekanshul wants to merge 1 commit into
ekanshul wants to merge 1 commit into
Conversation
The first overload of TTLCache.__init__ and TLRUCache.__init__ annotated self with fresh type variables (_KT2, _VT2) instead of the class-scoped _KT and _VT. Those method-scoped type variables are never solved from the arguments, so pyright infers TTLCache[_KT2, _VT2, float] and mypy infers TTLCache[Never, Never, float] even when the target type is declared. Use the class type variables in the self annotation (with the usual python#11780 pyright ignore, as in builtins.dict) and add test cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15798
Use the class type variables instead of fresh
_KT2/_VT2in theselfannotation of the firstTTLCache.__init__andTLRUCache.__init__overloads (with the usual#11780pyright ignore, as inbuiltins.dict), so type checkers can infer the key and value types; adds test cases for the issue examples.Agent used: Claude Code