Bump google-cloud-ndb to 2.5.* - #16248
Open
ekanshul wants to merge 2 commits into
Open
Conversation
google-cloud-ndb 2.5.1 adds an optional value=None parameter to future_info() on every _GlobalCache*Batch class and an optional server_op=None parameter to StructuredProperty.IN(). Update the stubs to match so stubtest passes, and drop the type: ignore[override] comments that are no longer needed now that the overrides are compatible with their base classes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15713
Bump google-cloud-ndb to 2.5.*, updating the
future_infosignatures in_cache.pyiandStructuredProperty.INinmodel.pyito match the new optional parameters added in 2.5.1 (which also makes thetype: ignore[override]comments unnecessary).Agent used: Claude Code