Skip to content

Use more reasonable timeouts for some jobs #156097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −36
Open

Use more reasonable timeouts for some jobs #156097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
runs-on: ubuntu-26.04
container:
image: ghcr.io/python/autoconf:2025.01.02.12581854023
timeout-minutes: 60
timeout-minutes: 5
needs: build-context
if: needs.build-context.outputs.run-tests == 'true'
steps:
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
# Don't use ubuntu-latest but a specific version to make the job
# reproducible: to get the same tools versions (autoconf, aclocal, ...)
runs-on: ubuntu-26.04
timeout-minutes: 60
timeout-minutes: 30
needs: build-context
if: needs.build-context.outputs.run-tests == 'true'
steps:
Expand Down Expand Up @@ -254,7 +254,7 @@ jobs:
build-ubuntu-ssltests:
name: 'Ubuntu SSL tests'
runs-on: ${{ matrix.os }}
timeout-minutes: 60
timeout-minutes: 10
needs: build-context
if: needs.build-context.outputs.run-ubuntu == 'true'
strategy:
Expand Down Expand Up @@ -328,7 +328,7 @@ jobs:
name: Android (${{ matrix.arch }})
needs: build-context
if: needs.build-context.outputs.run-android == 'true'
timeout-minutes: 60
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
Expand All @@ -350,7 +350,7 @@ jobs:
name: iOS
needs: build-context
if: needs.build-context.outputs.run-ios == 'true'
timeout-minutes: 60
timeout-minutes: 40
runs-on: macos-26
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand All @@ -375,7 +375,7 @@ jobs:
test-hypothesis:
name: "Hypothesis tests on Ubuntu"
runs-on: ubuntu-26.04
timeout-minutes: 60
timeout-minutes: 30
needs: build-context
if: needs.build-context.outputs.run-ubuntu == 'true'
env:
Expand Down Expand Up @@ -479,7 +479,7 @@ jobs:
build-asan:
name: 'Address sanitizer'
runs-on: ${{ matrix.os }}
timeout-minutes: 60
timeout-minutes: 30
needs: build-context
if: needs.build-context.outputs.run-ubuntu == 'true'
strategy:
Expand Down Expand Up @@ -550,7 +550,7 @@ jobs:
cross-build-linux:
name: Cross build Linux
runs-on: ubuntu-26.04
timeout-minutes: 60
timeout-minutes: 30
needs: build-context
if: needs.build-context.outputs.run-ubuntu == 'true'
steps:
Expand Down Expand Up @@ -632,7 +632,7 @@ jobs:
all-required-green: # This job does nothing and is only used for the branch protection
name: All required checks pass
runs-on: ubuntu-latest
timeout-minutes: 5
timeout-minutes: 2
needs:
- build-context # Transitive dependency, needed to access `run-tests` value
- check-docs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:
jobs:
lint:
runs-on: ubuntu-latest
timeout-minutes: 10
timeout-minutes: 5

steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mypy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
mypy:
name: Run mypy on ${{ matrix.target }}
runs-on: ubuntu-latest
timeout-minutes: 10
timeout-minutes: 5
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/new-bugs-announce-notifier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-slim
permissions:
issues: read
timeout-minutes: 10
timeout-minutes: 5
steps:
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/require-pr-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-slim
permissions:
pull-requests: read
timeout-minutes: 10
timeout-minutes: 2

steps:
- name: Check there's no DO-NOT-MERGE
Expand All @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-slim
permissions:
pull-requests: read
timeout-minutes: 10
timeout-minutes: 2

steps:
# Check that the PR is not awaiting changes from the author due to previous review.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-check-html-ids.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
check-html-ids:
name: 'Check for removed HTML IDs'
runs-on: ubuntu-latest
timeout-minutes: 30
timeout-minutes: 10
steps:
- name: 'Check out PR head'
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-cifuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
cifuzz:
name: ${{ inputs.oss-fuzz-project-name }} (${{ inputs.sanitizer }})
runs-on: ubuntu-latest
timeout-minutes: 60
timeout-minutes: 40
steps:
- name: Build fuzzers (${{ inputs.sanitizer }})
id: build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-context.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
compute-changes:
name: Create context from changed files
runs-on: ubuntu-latest
timeout-minutes: 10
timeout-minutes: 5
outputs:
run-android: ${{ steps.changes.outputs.run-android }}
run-ci-fuzz: ${{ steps.changes.outputs.run-ci-fuzz }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reusable-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
build-doc:
name: 'Docs'
runs-on: ubuntu-latest
timeout-minutes: 60
timeout-minutes: 10
env:
branch_base: 'origin/${{ github.event.pull_request.base.ref }}'
branch_pr: 'origin/${{ github.event.pull_request.head.ref }}'
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
doctest:
name: 'Doctest'
runs-on: ubuntu-26.04
timeout-minutes: 60
timeout-minutes: 15
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
Expand All @@ -141,7 +141,7 @@ jobs:
check-epub:
name: 'Check EPUB'
runs-on: ubuntu-latest
timeout-minutes: 30
timeout-minutes: 10
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build-install-test:
name: build, install and test
runs-on: ubuntu-26.04-arm
timeout-minutes: 60
timeout-minutes: 30
env:
PYTHONSTRICTEXTENSIONBUILD: 1
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
build-macos:
name: build and test (${{ inputs.os }})
runs-on: ${{ inputs.os }}
timeout-minutes: 60
timeout-minutes: 30
env:
HOMEBREW_NO_ANALYTICS: 1
HOMEBREW_NO_AUTO_UPDATE: 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-san.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
|| ''
}}
runs-on: ubuntu-26.04
timeout-minutes: 60
timeout-minutes: 40
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
build-ubuntu-reusable:
name: build and test (${{ inputs.os }})
runs-on: ${{ inputs.os }}
timeout-minutes: 60
timeout-minutes: 30
env:
OPENSSL_VER: 3.5.7
PYTHONSTRICTEXTENSIONBUILD: 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-wasi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build-wasi-reusable:
name: 'build and test'
runs-on: ubuntu-26.04-arm
timeout-minutes: 60
timeout-minutes: 30
env:
WASMTIME_VERSION: 38.0.3
CROSS_BUILD_WASI: cross-build/wasm32-wasip1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
build:
name: Build and test (${{ inputs.arch }}, ${{ inputs.interpreter }})
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}
timeout-minutes: 60
timeout-minutes: ${{ inputs.free-threading && 60 || 40 }}
env:
ARCH: ${{ inputs.arch }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
permissions:
actions: write
pull-requests: write
timeout-minutes: 10
timeout-minutes: 5

steps:
- name: "Check PRs"
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/tail-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
macos:
name: ${{ matrix.target }}
runs-on: ${{ matrix.runner }}
timeout-minutes: 60
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
Expand All @@ -39,9 +39,6 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.11'
- name: Install dependencies
run: |
brew update
Expand All @@ -60,7 +57,7 @@ jobs:
linux:
name: ${{ matrix.target }}
runs-on: ${{ matrix.runner }}
timeout-minutes: 60
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
Expand All @@ -78,9 +75,6 @@ jobs:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0

@webknjaz webknjaz Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd probably prefer to have this in a standalone PR, FWIW)

@StanFromIreland StanFromIreland Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to include it, it's just clean up after all. I presume it was copy-pasted from the JIT workflow. CC @Fidget-Spinner (I think you created tail-call.yml?)

@Fidget-Spinner Fidget-Spinner Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I dont think the tail call yanl file had any serious thought put into it in the initial impl by me. Feel free to improve it however you deem fit.

with:
python-version: '3.11'
- name: Build
run: |
# On ubuntu-26.04 image, clang is clang-21 by default
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-ensurepip-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ concurrency:
jobs:
verify:
runs-on: ubuntu-latest
timeout-minutes: 10
timeout-minutes: 5
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
Expand Down
Loading