Conversation
|
Valgrind is currently failing - https://github.com/python-pillow/Pillow/actions/runs/5460694184/jobs/9937936242?pr=7260 Also, I went to test the speed of image equality with this, radarhere@98e02aa... and found https://github.com/radarhere/Pillow/actions/runs/5461893489/jobs/9940492884#step:8:4787
|
|
oops, Py_NewRef wasn't added until Python 3.10. |
bbf5370 to
7eba51c
Compare
0e86ed9 to
17faca4
Compare
1f8077d to
d8012b3
Compare
f481c3c to
97a08ff
Compare
ff49d68 to
5322aaa
Compare
Py_True and Py_False were only made immortal in Python 3.12, so we have to properly increment their refcount for versions before that.
#9292 deprecated this. |
|
@radarhere Yep, tangentially related to #9883, but also #9938! I'm all for faster image comparison that doesn't involve dumping both images into a secondary buffer... I can do the work to forward-port this to the new mode ID stuff and so on. 👍 |
Imaging_Type/ImagingCore is exposed by Image.getdata(), so this allows you to properly compare the result of that method without it being an identity comparison. This should also speed up comparison between Image objects, because now the comparison is done in C instead of passing the data back to Python for it to be compared.