Repository navigation
Accelerator.add() utility function - #482
Conversation
…element to all available holders)
GamelinAl
left a comment
There was a problem hiding this comment.
Looks good.
An improvement would be to do this in a try/except block and to remove the names added so far from every holder in the except block. That way if it fails in the middle the configuration is still the starting one.
|
Arhg, interactive use will have objects dangling even if error is thrown... I'll fix it but there's no nice solution because you need to keep track of elements added during the function call. |
|
I've checked it works as intended now. The element is getting deleted if try fails. |
|
@TeresiaOlsson the current setting for merge looks fine (no need to bypass this one). |
Mm, that's good. The question is now if you weren't a maintainer could you still merge? I want to test that before I give all members write permissions. |
Added Accelerator.add() utility function to add elements to all modes and holders.
Resolves #420