Ignore volume of active fighters for fighterBayUsed - #2798
Open
WilliamWeist wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small logic change to ignore the volume of active fighter squads when calculating the volume of m3 used in the Fighters Bay.
In Eve the active squads are not in the Fighters Bay but in the Launch Tubes of the carrier or the supercarrier. When theory-crafting fits for those ships people have to take into consideration the fact that Pyfa store all the fighters in the Fighters Bay and manually do the math to calculate the amount of fighters the ships need to have under optimal condition. Removing active fighter squads from the volume used in the Fighters Bay let people easily simulate the action of moving fighters from the Fighters Bay to the Launch Tubes.