Conversation
Refresh the LZ4 work from pycompression#168 against current main. Co-authored-by: gonzo <gonzalosaenz@gmail.com> Co-authored-by: Marcel Martin <marcel.martin@scilifelab.se>
Dev-iL
force-pushed
the
lz4-pr168-refresh
branch
from
September 23, 2026 20:25
ee0b77f to
7be5cf2
Compare
Author
|
@marcelm @rhpvorderman Can you take a look please? |
Collaborator
|
I apologize for my previous comment about the AI code being unchecked. That was based on false assumptions and I should have been more wise than to make these. |
Dev-iL
force-pushed
the
lz4-pr168-refresh
branch
from
September 28, 2026 14:42
247fc66 to
07eea4c
Compare
rhpvorderman
approved these changes
Sep 29, 2026
rhpvorderman
left a comment
rhpvorderman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. @marcelm any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the LZ4 work from #168 on current
main(0818f20)..lz4extension and frame-header detection.pip install xopen[lz4], with thelz4program as a fallback when subprocesses are allowed. PyPy uses the CLI.-Tto older LZ4 binaries, adds a frame fixture and CLI/binding CI coverage, and makes Ruff's existing basic rule set explicit for newer Ruff releases.The original work was done by @gnzsnz, with contributions from @marcelm and others in #168. The commit preserves contributor credit.
AI Disclosure
Codex (GPT-6-Sol) was used to author this PR.