Repository navigation
Return None from master_key() for TLS 1.3 connections - #1545
Open
jaipaulcheernam wants to merge 1 commit into
Open
jaipaulcheernam wants to merge 1 commit into
jaipaulcheernam wants to merge 1 commit into
Conversation
TLS 1.3 has no master secret, so SSL_SESSION_get_master_key() reports a length of 0. master_key() asserted length > 0 and raised OpenSSL.SSL.Error([]) for TLS 1.3 connections; return None instead, matching the existing bytes | None return type. Fixes pyca#1544
jaipaulcheernam
force-pushed
the
master-key-tls13-none
branch
from
October 29, 2026 08:38
0dd77d2 to
a0d7c02
Compare
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Nov 2, 2026
- Patch is needed for openssl 4.1.0 upgrade and working on 4.0.3 as well - PR is opened upstream pyca/pyopenssl#1545 ptest results: PASS: 432 FAIL: 0 ERROR: 0 TOTAL: 1 FAIL: 0 Signed-off-by: Jaipaul Cheernam <jaipaul.cheernam@est.tech> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS 1.3 has no master secret, so SSL_SESSION_get_master_key() reports a length of 0. master_key() asserted length > 0 and raised OpenSSL.SSL.Error([]) for TLS 1.3 connections; return None instead, matching the existing bytes | None return type.
Fixes #1544