DOC: clarify default depo_veloc values in soiling.hsu Notes - #2854
DOC: clarify default depo_veloc values in soiling.hsu Notes#2854weixuan-song wants to merge 2 commits into
Conversation
Hey @weixuan-song! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content |
|
@weixuan-song, what are |
|
Thanks for the question, @williamhobbs. Those names ( To clarify: the
I have updated the PR description to remove those erroneous mode names and describe the change accurately. The code change itself (the expanded |
| The default values of ``depo_veloc`` correspond to the settling | ||
| velocity of particulates, i.e., only the gravitational movement of | ||
| particles. The model also accepts deposition velocities, which | ||
| comprise other types of particle-fluid interaction; however, the | ||
| authors of [1]_ found that deposition velocity considerably | ||
| overestimates soiling, while settling velocity performed well in | ||
| their case study. |
There was a problem hiding this comment.
| The default values of ``depo_veloc`` correspond to the settling | |
| velocity of particulates, i.e., only the gravitational movement of | |
| particles. The model also accepts deposition velocities, which | |
| comprise other types of particle-fluid interaction; however, the | |
| authors of [1]_ found that deposition velocity considerably | |
| overestimates soiling, while settling velocity performed well in | |
| their case study. | |
| As recommended by [1]_, the default values of ``depo_veloc`` | |
| are the settling velocities of particulates, i.e., only the gravitational | |
| movement of particles. |
|
Thanks for the suggestion, @cwhanse. I have applied it exactly as proposed — the |
1 similar comment
|
Thanks for the suggestion, @cwhanse. I have applied it exactly as proposed — the |
Description
Addresses #2535.
As discussed in the issue, the
depo_velocparameter ofsoiling.hsuis often left at its default (None), and the existing documentation did not make clear what those default values mean. The original paper notes that the velocity term in the model can represent either a deposition velocity (which accounts for various particle–fluid interactions beyond gravity) or a settling velocity (the gravitational movement of particles only). The authors found that using the deposition velocity considerably overestimates soiling, while the settling velocity performed well in their case study — and pvlib's defaultdepo_velocvalues correspond to the settling-velocity case.This PR expands the
Notessection ofsoiling.hsuto make that distinction explicit: the defaultdepo_velocvalues correspond to the settling velocity (gravitational motion only), and the model also accepts deposition velocities, which comprise other particle–fluid interactions and typically overestimate soiling.Changes:
pvlib/soiling.py: expanded theNotessection ofsoiling.hsuclarifying the defaultdepo_velocvalues and the meaning of settling velocity (default) vs. deposition velocity.docs/sphinx/source/whatsnew/v0.16.0.rst: added a Documentation entry referencing :issue:2535.No code behavior is changed; this is a documentation-only change.
Checklist
hsu-related tests inpvlib/tests/test_soiling.pypass)