Repository navigation
fix(catalogue): restore the line break before acknowledgments - #31
Merged
Merged
Conversation
#29 joined `acknowledgments:` onto the last package description, so .config/purview-docs.yml no longer parsed as YAML. purview.dev then fell back to its committed snapshot of this record, which still excludes Home.md and expects the index.md that #29 removed, and the site build failed with "no root page exists under docs/wiki".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#29 joined
acknowledgments:onto the end of thePurview.Containers.Aspirepackage description in.config/purview-docs.yml:The file then failed to parse (
Nested mappings are not allowed in compact mappings at line 87). purview.dev reads this record when it builds. Because the record couldn't be read, it fell back to its committed snapshot from 15 Nov. That snapshot still excludesHome.mdand relies on thedocs/wiki/index.mdthat #29 removed, so the site build failed:Failing run: https://github.com/purview-dev/purview-dev.github.io/actions/runs/44590097197
Fix
Put the line break back. The record parses again (15 packages, 2 acknowledgments,
docs/wikiwith only_Sidebar.mdexcluded), andpurview-site-assessmentreports no findings.Once this merges, re-run the purview.dev deploy.