Repository navigation
ci/update supported versions - #430
Merged
Merged
Conversation
edouard-lopez
commented
Oct 16, 2026
edouard-lopez
commented
Member
- ci(nix): replace unused FISH_VERSION by NIX_VERSION
- doc: update versions support strategy
- ci(nix): extract NIX_VERSION variable as env variable
- test: update base image to use to align with versioning support strategy
For Nix, we test against the local context so let's just build an image tagged with the Nix version we are using
There was a problem hiding this comment.
🟡 Changes recommended
A missing Make-level NIX_VERSION default breaks the documented local Nix build command.
1 open finding
What changed in this PR
Updates Pure’s supported-version policy and CI environments to match the revised distribution targets.
Changes:
- Expands the Fish/Alpine test matrix.
- Makes the Nix base image configurable through
NIX_VERSION. - Documents supported distributions and a Fish 3.6.x minimum.
| File | Description |
|---|---|
| makefile | Uses NIX_VERSION for Nix builds and containers. |
| docs/components/versioning-support-strategy.md | Updates supported versions and distributions. |
| docker/nix.Dockerfile | Parameterizes the Nix base image. |
| .github/workflows/nixos.yml | Sets and passes the Nix version. |
| .github/workflows/alpine.yml | Expands version coverage and removes Fish 3.3.1. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| --file ./docker/${STAGE}.Dockerfile \ | ||
| --build-arg FISH_VERSION=${FISH_VERSION} \ | ||
| --tag=pure-${STAGE}-${FISH_VERSION} \ | ||
| --build-arg NIX_VERSION=${NIX_VERSION} \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.