Repository navigation
req: the symbol-grep half of RATE-002's own re-promotion bar, and the record it asked for - #561
Merged
Merged
Conversation
… record it asked for
Both artifacts state the bar themselves: "the symbols present in shipped code
AND a `steps:` entry greping them, so the same prose-only-citation drift cannot
recur." FV-FALCON-RATE-002 also says what to do when the code arrives:
NO FAILING STEP WAS ADDED HERE, deliberately ... Adding
`grep -q 'u_delivered_frac'` now would redden a required check until the
branch lands ... The step gets added WITH the code, as the precondition
for re-promotion.
The code landed on 2026-10-13 in #556, so the step gets added. That is the
artifact's instruction, not a new policy.
WHAT THIS FIXES. #529's complaint has two halves and only one of them was about
absence: "the citation is PROSE, not a step, so the gate cannot see it." #556
flipped the absence by accident; the gate still could not see the drift in
EITHER direction. Four greps now bind the description's named mechanism to the
code: the `u_delivered_frac` field, `set_delivered_fraction` and
`last_torque_scale` as definitions, and the falcon-core call site that actually
wires it. Each was falsified by deleting the symbol in a copy and confirming
the grep fails; each matches code, not a comment. All 15 steps run and pass.
WHAT THIS DOES NOT DO, AND SAYS SO IN BOTH ARTIFACTS. #556 landed under the
title "the ring is anti-windup, not tuning", which these artifacts already
refute: the root cause is #488's `resync_loop_rate` (filters designed for 1 kHz
and stepped at 250 Hz; reverting it restores 2.47 rad/s), and "the ESO was
never the problem; the filter in front of it was". The passages asserting the
symbols are absent from main are now false and are corrected in place rather
than quietly dropped, in the same style the artifact used when it corrected
its own earlier "are fixed".
STATUS STAYS `implemented`. The re-promotion bar's other half is unmet: the
measured benefit (2.47 -> 2.02 -> 1.91 rad/s) remains VOID because it was taken
on the mis-designed filter, a regime that no longer exists, and nothing has
re-measured it against the fixed baseline. A gz run on 2026-10-13 (dispatch
38454332223) read 0.0015 rad/s pre-kill with the mechanism present against
0.00174 recorded without it — no regression, and no benefit either.
Maintainer decision 2026-10-13: keep the code, re-measure against the fixed
baseline, correct the record. This is the record half; the measurement is owed.
Refs #529, #270, #556
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HvusAXYbHLyv3uTzfBcMbG
avrabe
enabled auto-merge (squash)
October 13, 2026 20:28
Contributor
✅ Rivet verification gate — falcon174/174 passed
Bench-only artifacts (not run by CI)
Source of truth: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both artifacts state the bar themselves — "the symbols present in shipped code AND a
steps:entry greping them, so the same prose-only-citation drift cannot recur." AndFV-FALCON-RATE-002says what to do when the code arrives:The code landed on 2026-10-13 in #556. So the step gets added. That is the artifact's own instruction, not new policy.
What this fixes
#529's complaint has two halves, and only one was about absence: "the citation is PROSE, not a step, so the gate cannot see it." #556 flipped the absence by accident; the gate still couldn't see the drift in either direction.
Four greps now bind the description's named mechanism to the code:
u_delivered_fracrelay-adrc:133fn set_delivered_fractionrelay-adrc:245fn last_torque_scalerelay-mix-quad:264self.adrc.set_delivered_fractionfalcon-core:975Each was falsified by deleting the symbol in a copy and confirming the grep fails; each matches code, not a comment. All 15 steps run and pass (run from files, one per step).
What this does not do — and both artifacts now say so
#556 landed under the title "the ring is anti-windup, not tuning." These artifacts already refute that: the root cause is #488's
resync_loop_rate(filters designed for 1 kHz, stepped at 250 Hz; reverting it restores 2.47 rad/s), and "the ESO was never the problem; the filter in front of it was."The passages asserting the symbols are absent from
mainare now false. They are corrected in place rather than quietly dropped — the same style the artifact used when it corrected its own earlier "are fixed".Status stays
implementedThe bar's other half is unmet. The measured benefit (2.47 → 2.02 → 1.91 rad/s) is VOID — taken on the mis-designed filter, a regime that no longer exists — and nothing has re-measured it against the fixed baseline. A gz run on 2026-10-13 (dispatch
38454332223) read 0.0015 rad/s pre-kill with the mechanism present, against 0.00174 recorded without it: no regression, and no benefit either.Maintainer decision 2026-10-13: keep the code, re-measure against the fixed baseline, correct the record. This is the record half; the measurement is owed.
Refs #529, #270, #556
🤖 Generated with Claude Code
https://claude.ai/code/session_01HvusAXYbHLyv3uTzfBcMbG