Skip to content

Name the Off-Grammar --branch Outcome in AUDIT.md - #2695

Merged
ptr727 merged 2 commits into
developfrom
feature/auto-1509
Oct 10, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/auto-1509

Conversation

@ptr727

@ptr727 ptr727 commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Summary

The --branch paragraph in AUDIT.md named two outcomes of a --branch value: a ref that resolves, and a ref that does not resolve. It did not name the third, a value off the groundTruthBranch grammar, which spec/audit.py refuses before any read with exit 2 and one stderr line. This adds one sentence naming that outcome and where the grammar lives, GROUND_TRUTH_BRANCH_PATTERN in spec/validate.py.

The issue places the paragraph in section 1. It sits in section 8 ("Report"), and the edit is made where the paragraph actually is.

Verification

  • python3 spec/audit.py --branch 'a/../zen' ProjectTemplate printed one stderr line and exited 2, before any read.
  • scripts/prose_lint.py --diff origin/develop, scripts/repo_gate.py --check eol, spec/validate.py, and scripts/docker_lint.py (markdownlint, cspell) all pass.
  • Two local-strict-review passes ran over the branch diff and are recorded. The first found the new sentence over the 25-word cap, so it is split in two. The second found nothing.

Closes on promotion: #1509

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 9, 2026 22:03
The --branch paragraph described a ref that resolves and a ref that does
not, but not a value off the groundTruthBranch grammar, which spec/audit.py
refuses before any read with exit 2 and one stderr line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 10, 2026 05:05
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d30916f-f2b0-42d3-a510-0bc19ab23c04

📥 Commits

Reviewing files that changed from the base of the PR and between ff99b26 and 9d2d4d4.


📒 Files selected for processing (1)
  • AUDIT.md

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

0 open findings

What changed in this PR

Documents the invalid --branch outcome in AUDIT.md, including its grammar source and validation behavior.

Changes:

  • Names GROUND_TRUTH_BRANCH_PATTERN.
  • Documents rejection before reads with exit code 2.
File Description
AUDIT.md Clarifies invalid --branch handling.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@ff99b26). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2695   +/-   ##
==========================================
  Coverage           ?   59.58%           
==========================================
  Files              ?       16           
  Lines              ?     8317           
  Branches           ?        0           
==========================================
  Hits               ?     4956           
  Misses             ?     3361           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 59.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 10, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit a1bed9c into develop Oct 10, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-1509 branch October 10, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants