Repository navigation
Name the Off-Grammar --branch Outcome in AUDIT.md - #2695
Conversation
The --branch paragraph described a ref that resolves and a ref that does not, but not a value off the groundTruthBranch grammar, which spec/audit.py refuses before any read with exit 2 and one stderr line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
0 open findings
What changed in this PR
Documents the invalid --branch outcome in AUDIT.md, including its grammar source and validation behavior.
Changes:
- Names
GROUND_TRUTH_BRANCH_PATTERN. - Documents rejection before reads with exit code
2.
| File | Description |
|---|---|
AUDIT.md |
Clarifies invalid --branch handling. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2695 +/- ##
==========================================
Coverage ? 59.58%
==========================================
Files ? 16
Lines ? 8317
Branches ? 0
==========================================
Hits ? 4956
Misses ? 3361
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
Summary
The
--branchparagraph inAUDIT.mdnamed two outcomes of a--branchvalue: a ref that resolves, and a ref that does not resolve. It did not name the third, a value off thegroundTruthBranchgrammar, whichspec/audit.pyrefuses before any read with exit2and one stderr line. This adds one sentence naming that outcome and where the grammar lives,GROUND_TRUTH_BRANCH_PATTERNinspec/validate.py.The issue places the paragraph in section 1. It sits in section 8 ("Report"), and the edit is made where the paragraph actually is.
Verification
python3 spec/audit.py --branch 'a/../zen' ProjectTemplateprinted one stderr line and exited2, before any read.scripts/prose_lint.py --diff origin/develop,scripts/repo_gate.py --check eol,spec/validate.py, andscripts/docker_lint.py(markdownlint, cspell) all pass.local-strict-reviewpasses ran over the branch diff and are recorded. The first found the new sentence over the 25-word cap, so it is split in two. The second found nothing.Closes on promotion: #1509
🤖 Generated with Claude Code