Repository navigation
Annotate test fixtures instead of suppressing purity issues - #166
Merged
Merged
Conversation
The acceptance configs suppressed MissingPureAnnotation, MissingAbstractPureAnnotation, MissingImmutableAnnotation and MissingInterfaceImmutableAnnotation. Declare the purity of the fixture code instead. Annotated generator providers return iterable[pure], so the expected messages that print the provider type now include it. Claude-Session: https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW
They were marked read-props only because Psalm took generator functions without a return statement for void ones (vimeo/psalm#12421). Claude-Session: https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance test configs suppressed Psalm 7's missing purity/immutability annotation issues instead of the fixtures declaring them.
Before:
After:
Needs vimeo/psalm#12421: without it Psalm rejects
@psalm-pureon the generator providers.https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW