Release 0.3.0: isolate CONNECT headers per request - #71
Draft
cursor[bot] wants to merge 4 commits into
Draft
cursor[bot] wants to merge 4 commits into
cursor[bot] wants to merge 4 commits into
Conversation
Stop merging proxy CONNECT headers into origin response.headers and store them per connection so concurrent requests cannot mix CONNECT metadata. Adapters expose response.proxyHeaders instead. BREAKING CHANGE: read CONNECT headers from response.proxyHeaders, not response.headers. agent.lastProxyHeaders remains last-write-wins. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Keep the CONNECT-header isolation as a 0.x breaking change instead of 1.0.0. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Collaborator
|
cursor review |
Contributor
Author
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
Collaborator
|
cursor review |
Contributor
Author
Bugbot couldn't run — GitHub account mismatchThe GitHub account linked to your Cursor account does not match the PR author. Please ensure you're using the correct GitHub account, or run Bugbot from a team that covers this repository. |
Owner
|
cursor review |
Contributor
Author
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
Collaborator
|
bugbot run |
Contributor
Author
Bugbot couldn't run — GitHub account mismatchThe GitHub account linked to your Cursor account does not match the PR author. Please ensure you're using the correct GitHub account, or run Bugbot from a team that covers this repository. |
…aders Override typed-rest-client processResponse so RestClient results get per-request proxyHeaders. Sync ALS from reused sockets so make-fetch-happen keep-alive does not fall back to lastProxyHeaders. Attach proxyHeaders on axios error.response for non-2xx. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Cache hits never CONNECT, so ALS and the Response have no tunnel socket. Remember CONNECT headers from the live fetch by URL and restore them on hit instead of falling back to the shared agent's last-write-wins snapshot. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking 0.x release. CONNECT response headers are no longer merged into origin
response.headers, and they are stored per connection so concurrent requests cannot mix proxy metadata.Why
Shared
lastProxyHeadersplus copying CONNECT headers onto origin responses mixed hop-by-hop proxy metadata with the target HTTPS response. Concurrent clients could attribute another request’sX-ProxyMesh-IP, and a CONNECTSet-Cookie/Locationcould appear as origin headers.Breaking changes
response.proxyHeaders.get('x-proxymesh-ip'), notresponse.headers.agent.lastProxyHeadersis last-write-wins. Prefer per-responseproxyHeadersorgetProxyHeaders().0.2.4→0.3.0(package.jsonandjsr.json).What changed
lib/core/proxy-headers-store.js).proxyHeaders.Merging this
release/0.3.0branch intomainshould create GitHub releasev-0.3.0and publish.Please close #70 (wrong branch
release/1.0.0and 1.0.0 title).