Repository navigation
Avoid repeated prefix copies when checking quote escapes - #24
akshitkhokhani wants to merge 1 commit into
Conversation
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title "Avoid repeated prefix copies when checking quote escapes" matches the main change: fix_fast now counts adjacent backslashes backward from the quote instead of copying the preceding input. I… Description check The description explains that fix_fast copies the preceding input on each quote-escape check, and that the fix counts only adjacent backslashes. It also describes the added tests (slice-volume budget,… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "Avoid repeated prefix copies when checking quote escapes" matches the main change: fix_fast now counts adjacent backslashes backward from the quote instead of copying the preceding input. It is specific and concise, and a teammate scanning history would understand the primary change.
Full details: Description check
-
Explanation
The description explains that fix_fast copies the preceding input on each quote-escape check, and that the fix counts only adjacent backslashes. It also describes the added tests (slice-volume budget, complete and partial arrays, escaped string/key prefixes) and the validation run. This is directly related to the changeset.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
fix_fastcopies the entire preceding input whenever it checks whether a quote is escaped. Arrays containing many short strings therefore accumulate quadratic slice volume, including incomplete arrays received while streaming.Count only the adjacent backslashes before the quote instead. This preserves odd/even escape parity and avoids those repeated prefix copies.
Tests cover a deterministic slice-volume budget through
loads, complete and partial arrays, and every prefix of escaped string/key examples across all allowance flags. The new cases fail 6 tests on the original code (18 correctness controls pass).Validation: all 38 tests pass locally on Python 3.10 and 3.13. Tests use synthetic inputs with network access disabled. No claim is made about the complexity of the entire parser.
Developed with AI assistance and reviewed independently by a separate AI agent before submission.