Repository navigation
Keep NixOS module secrets out of the store and harden the nix CI job - #201
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kwsantiago
force-pushed
the
nix-hardening
branch
from
October 6, 2026 17:53
207bed7 to
704fec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NixOS module:
LoadCredential), so the relay's command line names/run/credentials/...rather than a store path.services.wisp.settingsFile: the absolute path to an extra config file kept outside the Nix store, for example root-owned 0600. It is loaded as a second credential and joined aftersettingsinto a 0600 file under/run/wisp. Its keys overridesettings. Firewall, sandbox and network ordering are still decided fromsettingsonly.secretnode that coverssettingsFile: the override, a leading top-level key not breaking[storage], the joined file's mode, and the command line.CI nix job:
accept-flake-config = false,require-sigs = true, and only cache.nixos.org as substituter and key.checks.x86_64-linux.wisp-module) runs on pushes to main and on pull requests that touchnix/,flake.nix,flake.lockor the workflow. The job timeout is raised to 30 minutes.Verified locally:
nix build .#,nix flake check(VM test) andscripts/verify-nix-deps.shpass.