Repository navigation
Add shared Settings, menu and About code with a surfaces command - #26
Merged
Merged
Conversation
Vendor the shared macOS surface sources under privacycommand/Sources/privacycommand/MacSurfaces with a lock of their hashes, and compile the folder into the app as a synchronized group. `just surfaces` refreshes the copy, a scheme pre-action runs the same step before each build, and `just check` verifies the copy against its lock. The shared code needs macOS 14, so the minimum moves from macOS 13 to 14. Nothing in the app uses the new types yet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
CI and TestFlight or release builds now only verify the committed copy, so a publication build never changes its own sources. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Version 8 tidies the vendored copy tool, .project/mac_surfaces.py, which the code quality review flagged: sync no longer returns check()'s always-None result, and the git lookup no longer ends in a bare except/pass. Behaviour is unchanged. The copy also moves from version 3 to the current Swift sources (the in-app manual and Keyboard Shortcuts windows among them), which the adoption PR stacked on this one already builds against. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings, the app menu and About are being moved onto one shared implementation. This brings that code into the repository and keeps it in step; it does not change any screen yet.
privacycommand/Sources/privacycommand/MacSurfaces: ten Swift files (Settings scaffold, About window, app and Help menu commands, popover header and footer, launch-at-login row, gated destructive buttons, Updates pane). The folder is added to the app target as a synchronized group, so files that later join or leave the copy need no project edit. All types are prefixedSurface, so nothing collides with existing code.just surfacesrefreshes the copy from the shared source when it is available on the machine, and otherwise verifies the committed files against.project/mac-surfaces.lock.json.privacycommandscheme runs the same step as a pre-action before each build. Xcode does not fail a build when a pre-action fails, sojust checkalso verifies the copy and fails if it was edited here.Package.swift, Info.plist and the README. The shared code uses APIs that start at 14.Validation:
just surfacesruns cleanly; the app builds unsigned with the new files compiled in, including the Sparkle conformance;just checkpasses.Moving the app's own Settings and About onto these types is a separate change.
🤖 Generated with Claude Code