Repository navigation
Conversation
Gemini's CONTINUATION finish reason means the per-request token limit was reached and generation is NOT complete. It had no case in FinishReasonMap and fell through to Other, so a caller checking for Length to detect a cut-off answer never saw it: a partial answer was presented as a finished one. python-genai 2.30/2.31 turn automatic continuation on by default, so servers are expected to send this in normal use. Resuming with the continuation token is a separate capability. The test enters through Prism::text(), not the map, and fails without the change. Reported in the Particle-Academy/prism fork as #82.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini's
CONTINUATIONfinish reason means the per-request token limit was reached and generation is not complete. It had no case inFinishReasonMapand fell through toOther, so a caller checkingFinishReason::Lengthto detect a cut-off answer never saw it, and a partial answer looked finished.python-genai 2.30/2.31 turn automatic continuation on by default, so this is expected in normal use. Resuming with the continuation token is a separate capability and not part of this.
The test enters through
Prism::text()and fails without the change. Three lines in the map, one test. Second of the smaller PRs out of #1028.