Repository navigation
feat: comment on a passage of a note, and ask Prax with @prax - #93
Merged
Merged
Conversation
Select text in a note (Space page or Library panel) and a Comment button appears; the threads sit under the note with reply, resolve/reopen and delete, and a comment on the whole note. Commented passages are highlighted with the CSS Custom Highlight API, which marks ranges without touching the rendered markdown; a thread whose passage was edited away says so. @prax in a comment or reply asks Prax: "Prax is replying…" until his answer arrives, by the library-changed nudge or, as a fallback, polling while he works. Comments are relayed to Prax, which stores them in the note. MarkdownContent now memoises its react-markdown components. A new object on every render gave react-markdown new component types, so any parent re-render rebuilt the whole rendered DOM: it dropped a selection in progress and the highlight ranges, and re-mounted every chat message for nothing.
praxagent
force-pushed
the
feat/library-comments
branch
from
October 4, 2026 21:05
20af81e to
d6d9cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment on a passage of a note, and ask Prax with
@prax. Prax side: praxagent/prax#272 (stacked on prax #270). Rebased ontomainafter #90 merged; merges cleanly with #91 in either order (checked locally).What changes
Comments in the note view (Space page and Library panel).
@prax. "Prax is replying…" shows until his answer arrives, by the existing library-changed nudge or, as a fallback, by polling every 4 s while he works. Comments are relayed to Prax, which stores them in the note.MarkdownContentmemoises its react-markdowncomponents.Verification
NoteComments.test.tsx(9): matching a passage across paragraphs and by prefix, threads, Prax replying, a missing passage, reply and resolve, and a whole-note comment.MarkdownContent.rerender.test.tsx.tests/test_library_comments.py: the relay.make cigreen (522 after the rebase), all 145 frontend tests pass, and lint has no new warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01NzJXnMXFAX7Km7aDmRc6zX