Repository navigation
fix(push): prevent lost notifications and missing images - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a push cold-starts the app,
onMessageReceivedreturned before the notificationwas built. Firebase then destroyed the messaging service and
PushNotificationDelegate.onDestroy()cancelled the in-flight image download:JobCancellationException, nonotify()),the notification was posted without its image.
Fix
onMessageReceivedwaits on the messaging worker thread until the notification is posted;calls from the main thread keep the async path to avoid ANRs
onDestroy()no longer cancels in-flight workany other failure posts the notification without the image
CancellationExceptionis no longer swallowedNo public API changes (
apiCheckpasses), so integrations forwarding messages throughFcmMessagingServiceDelegateget the fix by bumping the version.Tests
PushNotificationDelegateTest: service destroyed mid download, transient network error,non-retryable error. The first two fail without the fix and pass with it.