Repository navigation
Fix issues compiling against rtmidi 6.1 - #585
Merged
Merged
Conversation
- Versions 6.1 and above use the rt::midi namespace, and we set RTMIDI_USE_NAMESPACE to avoid having them also added in the global scope. To support building against older versions, we import the namespace only in the .C files. - Switch MidiOutputDevice to use the pimpl idiom to hide its implementation. This is a bit simpler and avoids having to deal with the new rtmidi namespace for forward declarations.
cameronwhite
added a commit
that referenced
this pull request
Nov 1, 2026
RtMidi 6.1 seems to report the "dummy" API in addition to the valid Core Midi API Related to PR #585
Contributor
|
fix #582 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions 6.1 and above use the rt::midi namespace, so we set RTMIDI_USE_NAMESPACE to avoid having them also added in the global scope. To support building against older versions, we import the namespace for now in the .C files.
Switch MidiOutputDevice to use the pimpl idiom to hide its implementation. This is a bit simpler and avoids having to deal with the new rtmidi namespace possibly not being present for forward declarations.