Repository navigation
Redesign the video texture example - #9913
Merged
Merged
Conversation
A kinetic wall of tiles and a rounded cube play the video, uploaded only on new frames, with an sRGB texture and an area light following the average color of the video.
Build size reportThis PR does not change the size of the minified bundles.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the
graphics/video-textureexample, which showed a washed-out video on a swinging slab, as a dark scene where one video texture plays on two surfaces.Changes:
RoundedBoxGeometry) tumbles in front of the wall, with the whole video on each face.RGBA8texture was sampled as linear, which washed it out.requestVideoFrameCallback), falling back to an upload every frame.Texture#read, and lights the floor with it.Examples:
graphics/video-texture: redesigned, with new thumbnails