Repository navigation
Conversation
Bound every client-supplied path in the file-listing example to the server's working directory. list_files, get_file_info, file://read and watch_files now resolve paths against an explicit root and reject any destination that escapes it, including '..' traversal and symlinks resolved after fs.realpath. This hardening addresses GHSA-3439-r3q5-g34g.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file-listing example passed client-supplied paths straight to
join(process.cwd(), path), so itslist_files,get_file_info,file://read, andwatch_filesoperations accepted../traversal and could reach files outside the working directory with the privileges of the server process. Thefile://readresource also percent-decoded itspathquery parameter throughURLSearchParamsbefore touching the filesystem.This change resolves every destination against an explicit root and rejects anything that escapes it. Containment is checked against the symlink-resolved path so a symlink pointing outside the root is rejected too. This hardens the example without changing the library itself, addressing GHSA-3439-r3q5-g34g.