Fix undefined commit hash in deployment detail view

[vikash7485]

What this PR does:

Guard against undefined or null deployment.trigger.commit.hash in the DeploymentDetail component (web/src/components/deployments-detail-page/deployment-detail/index.tsx). When hash is missing, use a safe fallback "" instead of directly calling .slice(0, 7).

Why we need it:

In DeploymentDetail, the commit hash was directly sliced (deployment.trigger.commit.hash.slice(0, 7)). If a deployment contains a trigger commit object without a hash field (e.g. from an incomplete gRPC response or synthetic test payload), it throws an unhandled TypeError: Cannot read properties of undefined (reading 'slice') and crashes the entire component rendering.

Does this PR introduce a user-facing change?:

Yes. Fixes a potential UI crash on the deployment detail page.

• How are users affected by this change: Users will no longer encounter a blank screen / runtime crash when viewing deployments that have missing commit hash values.
• Is this breaking change: No.
• How to migrate (if breaking change): N/A.

[netlify]

✅ Deploy Preview for pipecd-site canceled.

Name	Link
🔨 Latest commit	e5e7eb1
🔍 Latest deploy log	https://app.netlify.com/projects/pipecd-site/deploys/6a95d1d250981e00086e46d6

[Copilot]

Pull request overview

This PR prevents a runtime crash in the web UI’s deployment detail page by safely handling cases where deployment.trigger.commit.hash is missing, ensuring the component can render even with incomplete deployment payloads.

Changes:

• Guard deployment.trigger.commit.hash before slicing to avoid TypeError crashes.
• Add a unit test that verifies DeploymentDetail renders when the commit hash is undefined.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
web/src/components/deployments-detail-page/deployment-detail/index.tsx	Uses a safe fallback ("") before slicing the commit hash to prevent crashes.
web/src/components/deployments-detail-page/deployment-detail/index.test.tsx	Adds coverage for rendering when the commit hash is undefined.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

web/src/components/deployments-detail-page/deployment-detail/index.test.tsx:48

• DeploymentTrigger.AsObject.commit is an optional field (commit?: Commit.AsObject), so spreading ...dummyTrigger.commit will fail type-checking because the spread operand may be undefined. Narrow or assert the type before spreading.

          ...dummyTrigger.commit,

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[mohammedfirdouss]

Thank you for the contributions @vikash7485

[github-actions]

Thank you for contributing to PipeCD, @vikash7485! The changes in this pull request will be part of the upcoming release!