i18n(ja): restore the link-embedded-in-bold checkbox label to English - #23564
Open
yahonda wants to merge 3 commits into
Open
i18n(ja): restore the link-embedded-in-bold checkbox label to English#23564yahonda wants to merge 3 commits into
yahonda wants to merge 3 commits into
Conversation
The "Use [TiDB file naming conventions](link) for automatic mapping" / "Use [File naming conventions](link) for automatic mapping" checkbox label had its embedded link split incorrectly across straddling Japanese quote marks and particle boundaries in 7 import-*.md files, producing garbled option labels. Restore the exact English label with the link correctly nested inside the bold span, matching the English source structure. Also fixes one dropped を particle found in the same sentence in premium/import-csv-files-premium.md.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Important Review skippedToo many files! This PR contains 233 files, which is 83 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (233)
You can disable this status message by setting the 📝 WalkthroughWalkthroughThe PR updates Japanese TiDB Cloud import documentation to use English automatic-mapping UI labels. It covers CSV, Parquet, and sample-data guides across supported cloud storage providers. Existing import behavior and SQL format instructions remain unchanged. ChangesImport documentation label updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized documentation wording and link-label corrections across seven import guides; no actionable merge-blocking risk remains, so it is merge-ready after normal checks and review. Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qiancai
added
translation/no-need
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f9e7432b-fa5a-4532-9f1d-e9b6c5762137
📒 Files selected for processing (7)
tidb-cloud/import-csv-files-serverless.mdtidb-cloud/import-csv-files.mdtidb-cloud/import-parquet-files-serverless.mdtidb-cloud/import-parquet-files.mdtidb-cloud/import-sample-data-serverless.mdtidb-cloud/import-sample-data.mdtidb-cloud/premium/import-csv-files-premium.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
This was referenced Aug 19, 2026
The English source never wraps a bold UI-label span (e.g. Click **Connect**) in quotes, but the ja translation had accumulated 「」 around many such spans (e.g. **「接続」**), across single-word button labels, symbols (**「+」**, **「...」**), and longer descriptive labels (**「クラウドストレージからデータをインポート」**). Verified this pattern holds against EN for a representative sample across short and long labels before doing a mechanical, corpus-wide strip: **「X」** -> **X**, applied only where the quote marks sit immediately inside the bold delimiters (1,577 occurrences across 233 files). This supersedes the narrower carve-outs used in PR pingcap#23551/pingcap#23552, which kept a handful of terms quoted for in-file convention (接続 タイプ, スキーマロード, 接続方法, 組織設定, etc.) - per the standing policy, in-file consistency is not a reason to keep quoting a term EN never quotes. Verified per-file: line count, ** count, [ count, and ] count are all unchanged (0 anomalies across all 233 changed files) - only the 「」 characters were removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 tasks
…ld-2026-08-19 Resolved 6 file conflicts: took this branch's link-embedded-in-bold fix as the base, then re-applied the quote-stripping substitution on top. Verified 0 remaining quote-wrapped bold spans (including a whole-tree second pass) and 0 bracket-count anomalies. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ti-chi-bot
Bot
added
the
area/develop
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ti-chi-bot
Bot
added
size/XXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
EN bolds a whole checkbox-option label that has a link nested inside it:
**Use [TiDB file naming conventions](link) for automatic mapping**(or, for Serverless/Premium docs,**Use [File naming conventions](link) for automatic mapping**). In 7 import-*.md files, this got garbled during translation: the Japanese quote marks and the を/の particles were split incorrectly across the link boundary, producing nonsensical option labels like**「自動マッピングに<a href="...">TiDBファイル命名規則を</a>使用する」**.tidb-cloud/import-csv-files.md,tidb-cloud/import-csv-files-serverless.md,tidb-cloud/import-parquet-files.md,tidb-cloud/import-parquet-files-serverless.md,tidb-cloud/import-sample-data.md,tidb-cloud/import-sample-data-serverless.md,tidb-cloud/premium/import-csv-files-premium.md.premium/import-csv-files-premium.md.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit