Repository navigation
Conversation
The preview printed the longitude under 'Lat.' and the latitude under 'Long.'. The imported value was already correct; only the text changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Member
Author
|
Superseded by #720, which carries the same change on 2026.3. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized correction fixes the label swap and includes a targeted regression test, with no unresolved findings.
No open issues 🎉
What changed in this PR
Corrects swapped latitude/longitude labels in the AsGeopoint mapping preview without changing import behavior.
Changes:
- Uses the matching coordinate getter for each preview label (
src/Mapping/Operator/Factory/AsGeopoint.php:44). - Adds a regression test with distinct latitude and longitude values (
tests/unit/FactoryOperatorTest.php:438–446).
The full Codeception suite was not verified.
| File | Description |
|---|---|
| tests/unit/FactoryOperatorTest.php | Adds regression coverage for preview labels. |
| src/Mapping/Operator/Factory/AsGeopoint.php | Corrects coordinate getters in preview output. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AsGeopoint::generateResultPreview()now prints the latitude afterLat.:and the longitude afterLong.:.Why
The preview used
getLongitude()for theLat.label andgetLatitude()forLong., so the mapping preview showed the values swapped.process()was already correct (GeoCoordinates(lat, lon)), so imported data is unaffected; only the preview text changes.Fixes #447
Verification
FactoryOperatorTest::testAsGeopointPreviewLabelsLatitudeAndLongitudefails on base 3d43f44 (Lat.: 2.3522 Long.: 48.8566), passes on 042d9d9 (run on the host with the committed test method; the Codeception suite itself needs the kernel/DB and was not run).--allow-risky=yes) clean on the changed source file; PHPStan not run (swap of two getter calls, no type change).Lat.: 2.3522 Long.: 48.8566, fix showsLat.: 48.8566 Long.: 2.3522.Not verified
The classic admin; the import itself (code reading only,
process()is unchanged); the full Codeception suite in CI.🤖 Generated with Claude Code