Skip to content

Added system field "key" as optional argument for data object mutation - #987

Merged
kingjia90 merged 3 commits into
pimcore:2.xfrom
holz-richter:mutation-type-key
Sep 22, 2025
Merged

kingjia90 merged 3 commits into
pimcore:2.xfrom
holz-richter:mutation-type-key

Conversation

@SimonCremer

Copy link
Copy Markdown
Contributor

The field "key" is a system field and should be treated the same way during both creation and updating. While it's possible to add the "key" field to the mutation configuration, this would mean that during creation, "key" would exist both as a parameter and a field on the input object, which can be confusing. In the update case, it would only be available as a field on the input object. Since "key" is required during creation, the parameter must be kept.

@github-actions

github-actions Bot commented Aug 15, 2025 •

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sonarqubecloud

Copy link
Copy Markdown

@SimonCremer

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@SimonCremer

Copy link
Copy Markdown
Contributor Author

@fashxp Are there any plans if (and when) the change will be merged?

@fashxp

fashxp commented Sep 11, 2025

Copy link
Copy Markdown
Member

It is on our list for the next platform version end of this month.

@kingjia90 kingjia90 self-assigned this Sep 22, 2025
Comment thread src/GraphQL/Mutation/MutationType.php Resolved
@kingjia90 kingjia90 added this to the 2.2.0 milestone Sep 22, 2025
@sonarqubecloud

Copy link
Copy Markdown

@kingjia90
kingjia90 merged commit 82b3fba into pimcore:2.x Sep 22, 2025
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Treat system field "key" the same way in create and update of data objects

3 participants