[diffs] Parse the icon sprite once per document - #1106
Open
mds-ant wants to merge 1 commit into
Open
Conversation
…ance `File` and `FileDiff` re-parsed the ~8.5 KB `SVGSpriteSheet` markup with `innerHTML` every time an instance mounted its shadow root. On pages with many instances that parse is a noticeable share of mount cost, and it produces the same nodes every time. `createSVGSpriteElement()` now parses the markup once per `document` (kept in a `WeakMap`, so a fresh jsdom document in tests gets its own copy) and returns a deep clone on each call. `ensureSpriteSVG` in both components uses it; the resulting DOM is unchanged. The helper is internal and not exported.
|
@mds-ant is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createSVGSpriteElement()now parses the markup once perdocument(kept in aWeakMap, so a fresh jsdom document in tests gets its own copy) and returns a deep clone on each call. On pages that mount many instances, this is cheaper and faster than repeatedly parsing the theSVGSpriteSheetmarkup.Motivation & Context
FileandFileDiffre-parsed the ~8.5 KBSVGSpriteSheetmarkup withinnerHTMLevery time an instance mounted its shadow root. On pages with many instances that parse is a noticeable share of mount cost, and it produces the same nodes every time.Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
moon run root:lint)moon run root:format)moonx diffs:test)How was AI used in generating this PR
The code for this performance improvement was written by Claude Code.