Repository navigation
DRY: single parameterised Dockerfile and matrix CI - #75
Merged
Merged
Conversation
Opcache package is only installed for PHP < 8.5 (built into core from 8.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the five per-version Dockerfiles with one root
Dockerfiledriven byPHP_VERSIONandUBUNTUbuild args.overrides.conf(8.2 to 8.5 were identical; 8.1 differed by one comment).php<V>-opcacheis installed only for PHP < 8.5; opcache is built into core from 8.5, so 8.6+ needs no change./usr/sbin/php-fpmtophp-fpm<V>, soCMDis["/usr/sbin/php-fpm", "-O"].includelist mapping each version to jammy or noble. Cache scopes are per version and target. PRs build all images but only master pushes..dockerignore; removedphp/<ver>/including stale READMEs.Not verified locally (no Docker daemon available); CI on this PR is the first real build.
Breaking:
docker build php/<ver>no longer works. Use the root context with build args.