Repository navigation
cmd+w should close active tab and not the whole window - #1544
Merged
Merged
Conversation
Note: bindWindowCloseShortcut acts at widget level because the API to update key bindings is not available at spec layer. Should be adressed later
jecisc
approved these changes
Oct 7, 2026
jecisc
left a comment
jecisc
left a comment
Member
There was a problem hiding this comment.
I tried it and thank you a lot! Works like a charm in the scenarios I tried! :)
Member
|
The approval was for the feature but you removed some test classes that are used: 
|
demarey
force-pushed
the
fix-closing-method-browser
branch
from
October 7, 2026 13:11
5e54ef6 to
ad0db97
Compare
jecisc
removed
the
need more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: bindWindowCloseShortcut acts at widget level because the API to update key bindings is not available at spec layer. Should be addressed later