Repository navigation
Add CleanBlockClosure Tost support and repoint StateSpecs/ObjectTravel for Pharo 13 - #12
Open
oliveiraallex wants to merge 1 commit into
Open
oliveiraallex wants to merge 1 commit into
oliveiraallex wants to merge 1 commit into
Conversation
…l for Pharo 13 - Add TostSerializer/CleanBlockClosure.extension.st (createTostInstanceWith:/writeTostBodyWith:/correctTostMaterializationWith: for CleanBlockClosure, needed on Pharo 13 where constant/clean blocks are CleanBlockClosure instances) - BaselineOfTostSerializer: repoint StateSpecs to github://dionisiydk/StateSpecs:v5.0.4 and ObjectTravel to github://pharo-ide/ObjectTravel:v1.0.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Pharo 13, constant/clean blocks materialize as
CleanBlockClosureinstances (a dedicated subclass introduced in recent Pharo versions).TostSerializerhad no explicit handling for this class, so those blocks fell through to the genericObjectserialization path and failed to round-trip correctly. The new extension givesCleanBlockClosurethe same simplified treatmentFullBlockClosurealready has, since both have no difference in binary representation across 32/64-bit images.Changes
TostSerializer/CleanBlockClosure.extension.st:createTostInstanceWith:,writeTostBodyWith:, andcorrectTostMaterializationWith:forCleanBlockClosure, mirroring the existing support already implemented forFullBlockClosure.BaselineOfTostSerializer: repointStateSpecsfromv5.0.2tov5.0.4, andObjectTravelfromv1.0.4tov1.0.5(target tags of the Pharo 13 dependency chain), referencied on: Update BaselineOfSeamless dependency pointers for Pharo 13 Seamless#56