Skip to content

Fix isActiveProcess deprecation and repoint Mocketry to v7.0.4 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliveiraallex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix isActiveProcess deprecation and repoint Mocketry to v7.0.4 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BaselineOfBasys/BaselineOfBasys.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ BaselineOfBasys >> baseline: spec [
project: 'TCPServerTests' copyFrom: 'TCPServer' with: [
spec loads: 'Tests'];
baseline: 'Mocketry' with: [
spec repository: 'github://dionisiydk/Mocketry:v7.0.2' ].
spec repository: 'github://dionisiydk/Mocketry:v7.0.4' ].
spec
package: 'Basys' with: [ spec requires: #('TCPServerCore')];
package: 'Basys-Tests' with: [ spec requires: #('Basys' 'TCPServerTests' 'Mocketry')].
Expand Down
2 changes: 1 addition & 1 deletion Basys/BasysConnection.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ BasysConnection >> close [
And there are two cases where the actual close needs to be performed directly:
- data process is not started yet
- data process is in very beggining step where it is not able to handle the termination"
(incomingDataProcess notNil and: [ incomingDataProcess isActiveProcess not ]) ifTrue: [
(incomingDataProcess notNil and: [ incomingDataProcess isActive not ]) ifTrue: [
"Here the close is performed from the outside of the connection (not under the data process)"
incomingDataProcess terminate.
"If terminate really did the close it will nil the process variable. And therefore the return"
Expand Down
Loading