Skip to content

chore: housekeeping leftovers from the Codacy cleanup - #89

Merged
petercorke merged 2 commits into
mainfrom
chore/housekeeping-leftovers
Oct 31, 2026
Merged

petercorke merged 2 commits into
mainfrom
chore/housekeeping-leftovers

Conversation

@petercorke

Copy link
Copy Markdown
Owner

Part of #23. The last of its checklist, with #87 (the __repr__) and #88 (the B101 asserts).

What

  • Delete posegraph.py from the repository root. It is a 2020 prototype that nothing references: it imports the deprecated UVertex, map() is a pass stub, it has debug prints, and it uses itertools.pairwise (Python 3.10) in a package that supports 3.9. The Robotics Toolbox has the real PoseGraph, and this stays in git history.

  • examples/create_json.py: info.pop('dgoal', None) instead of a try/bare except/pass around a del.

  • Pin the two remaining third-party Actions to commit SHAs, with the version in a comment, as RTB did in ci: pin third-party GitHub Actions to commit SHAs robotics-toolbox-python#892 (see rvc-ecosystem#24):

    • codecov/codecov-action v7.1.1 = 303a32d7a59b442fa8d48b6a1cc6825c09c847a5
    • dependabot/fetch-metadata v3.1.0 = 25dd0e34f4fe68f24cc83900b1fe3fe149efef98

    I resolved both through the GitHub API (annotated tags followed to their commit). They are the commits the floating @v7 and @v3 tags point to today, so what runs does not change. GitHub's own actions/* stay on tags, as in RTB, and pypa/gh-action-pypi-publish was already pinned. Dependabot updates a pinned SHA together with its comment.

  • Ignore build/ as well as docs/build and dist/.

Checking

pytest tests: 772 passed. Both workflow files still parse as YAML. The Codecov step in ci.yml and the Dependabot workflow are only exercised by CI itself, so this PR's checks are the real test of the ci.yml pin.

🤖 Generated with Claude Code

- Delete posegraph.py, a 2020 prototype in the repository root that nothing
  uses: it imports the deprecated UVertex, has a stub method and debug prints,
  and needs itertools.pairwise (Python 3.10) in a package that supports 3.9.
  The Robotics Toolbox has the real PoseGraph.
- examples/create_json.py: pop('dgoal', None) instead of a bare except.
- Pin the two remaining third-party GitHub Actions to commit SHAs with the
  version in a comment, as RTB did in petercorke/robotics-toolbox-python#892:
  codecov/codecov-action v7.1.1 and dependabot/fetch-metadata v3.1.0.  They are
  the commits that @v7 and @V3 point to today, so what runs is unchanged.
  GitHub's own actions/* stay on tags, and Dependabot updates a pinned SHA with
  its comment.
- Ignore build/ as well as docs/build and dist/.

Part of #23.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.05%. Comparing base (bffb7be) to head (0cf0dd0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files           4        4           
  Lines        1590     1590           
=======================================
  Hits         1559     1559           
  Misses         31       31           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke
petercorke merged commit 17b8470 into main Oct 31, 2026
12 checks passed
@petercorke
petercorke deleted the chore/housekeeping-leftovers branch October 31, 2026 03:37
@petercorke petercorke mentioned this pull request Oct 31, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant