Repository navigation
chore: housekeeping leftovers from the Codacy cleanup - #89
Merged
Merged
Conversation
- Delete posegraph.py, a 2020 prototype in the repository root that nothing
uses: it imports the deprecated UVertex, has a stub method and debug prints,
and needs itertools.pairwise (Python 3.10) in a package that supports 3.9.
The Robotics Toolbox has the real PoseGraph.
- examples/create_json.py: pop('dgoal', None) instead of a bare except.
- Pin the two remaining third-party GitHub Actions to commit SHAs with the
version in a comment, as RTB did in petercorke/robotics-toolbox-python#892:
codecov/codecov-action v7.1.1 and dependabot/fetch-metadata v3.1.0. They are
the commits that @v7 and @V3 point to today, so what runs is unchanged.
GitHub's own actions/* stay on tags, and Dependabot updates a pinned SHA with
its comment.
- Ignore build/ as well as docs/build and dist/.
Part of #23.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 4 4
Lines 1590 1590
=======================================
Hits 1559 1559
Misses 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #23. The last of its checklist, with #87 (the
__repr__) and #88 (the B101 asserts).What
Delete
posegraph.pyfrom the repository root. It is a 2020 prototype that nothing references: it imports the deprecatedUVertex,map()is apassstub, it has debugprints, and it usesitertools.pairwise(Python 3.10) in a package that supports 3.9. The Robotics Toolbox has the realPoseGraph, and this stays in git history.examples/create_json.py:info.pop('dgoal', None)instead of atry/bareexcept/passaround adel.Pin the two remaining third-party Actions to commit SHAs, with the version in a comment, as RTB did in ci: pin third-party GitHub Actions to commit SHAs robotics-toolbox-python#892 (see rvc-ecosystem#24):
codecov/codecov-actionv7.1.1=303a32d7a59b442fa8d48b6a1cc6825c09c847a5dependabot/fetch-metadatav3.1.0=25dd0e34f4fe68f24cc83900b1fe3fe149efef98I resolved both through the GitHub API (annotated tags followed to their commit). They are the commits the floating
@v7and@v3tags point to today, so what runs does not change. GitHub's ownactions/*stay on tags, as in RTB, andpypa/gh-action-pypi-publishwas already pinned. Dependabot updates a pinned SHA together with its comment.Ignore
build/as well asdocs/buildanddist/.Checking
pytest tests: 772 passed. Both workflow files still parse as YAML. The Codecov step inci.ymland the Dependabot workflow are only exercised by CI itself, so this PR's checks are the real test of theci.ymlpin.🤖 Generated with Claude Code