Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/.snapshots/success.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2288,6 +2288,8 @@
✓ parallel records the test run history
✓ parallel does not record the test run history when asked not to with ('--do-not-cache-result')
✓ parallel does not record the test run history when asked not to with ('--do-not-record-test-run-history')
✓ parallel group-filtered run is not considered empty when a worker ends on a fully filtered file
✓ parallel group-filtered run still fails when the selection matches no tests

PASS Tests\Visual\ParallelNestedDatasets
✓ parallel loads nested datasets from nested directories
Expand Down Expand Up @@ -2321,4 +2323,4 @@
✓ pass with dataset with ('my-datas-set-value')
✓ within describe → pass with dataset with ('my-datas-set-value')

Tests: 2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 37 skipped, 1648 passed (3649 assertions)
Tests: 2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 37 skipped, 1650 passed (3653 assertions)
5 changes: 5 additions & 0 deletions tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ATest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

it('belongs to the filtered group', function () {
expect(true)->toBeTrue();
})->group('filtered');
5 changes: 5 additions & 0 deletions tests/Fixtures/Suites/ParallelGroupFilteredLastFile/ZTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

it('does not belong to the filtered group', function () {
expect(true)->toBeTrue();
});
26 changes: 26 additions & 0 deletions tests/Visual/Parallel.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,29 @@
'--do-not-cache-result',
'--do-not-record-test-run-history',
])->skipOnWindows();

test('parallel group-filtered run is not considered empty when a worker ends on a fully filtered file', function (): void {
$process = new Process(
['php', 'bin/pest', '--parallel', '--processes=1', '--group=filtered', 'tests/Fixtures/Suites/ParallelGroupFilteredLastFile'],
dirname(__DIR__, 2),
['COLLISION_PRINTER' => 'DefaultPrinter', 'COLLISION_IGNORE_DURATION' => 'true', 'PAO_DISABLE' => '1'],
);

$process->run();

expect(removeAnsiEscapeSequences($process->getOutput()))->toContain('Tests: 1 passed (1 assertions)')
->and($process->getExitCode())->toBe(0);
})->skipOnWindows();

test('parallel group-filtered run still fails when the selection matches no tests', function (): void {
$process = new Process(
['php', 'bin/pest', '--parallel', '--processes=3', '--group=missing', 'tests/Fixtures/Suites/ParallelGroupFilteredLastFile'],
dirname(__DIR__, 2),
['COLLISION_PRINTER' => 'DefaultPrinter', 'COLLISION_IGNORE_DURATION' => 'true', 'PAO_DISABLE' => '1'],
);

$process->run();

expect(removeAnsiEscapeSequences($process->getOutput()))->toContain('No tests found.')
->and($process->getExitCode())->toBe(1);
})->skipOnWindows();
Loading