Repository navigation
fix: check each target in negated toUse - #1933
Open
tiagoabsantos wants to merge 8 commits into
Open
tiagoabsantos wants to merge 8 commits into
tiagoabsantos wants to merge 8 commits into
Conversation
A skipped class in expect([...]) made the positive rule fail, so the negation passed even when another class used the dependency. Fixes pestphp#1751
1 of 2 tasks
added 7 commits
October 26, 2026 09:07
Negated toUse coverage adds 6 tests and 24 assertions, so the success snapshot and parallel totals were stale.
Snapshot totals add the notToUse coverage on top of the numeric table tests from 5.x.
Snapshot totals keep the six notToUse tests and 24 assertions on top of current 5.x.
Snapshot totals keep the six notToUse tests and 24 assertions on top of current 5.x.
Keep per-subject negated toUse checks and adopt the SingleArchExpectation type from 5.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
expect([...])->not->toUse()passed whenever any target skipped the dependency, even if another target used it. Each subject is now checked on its own, so one violating class fails the negated rule.Related:
Fixes #1751