Skip to content

drop the focus outline from chat's conversation #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkonsti merged 1 commit into from
Nov 11, 2026
+4 −2
Merged

drop the focus outline from chat's conversation #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/web/src/components/chat/message-scroller.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ function MessageScroller({

// The viewport fades out at its bottom while there is more below. A browser that can drive the
// fade from the scroll position does (shadcn's scroll-fade); for one that can't, the viewport
// says whether it is scrolled to the end, and the stylesheet lifts the fade there.
// says whether it is scrolled to the end, and the stylesheet lifts the fade there. It takes focus
// so the arrow keys scroll it, but shows no outline for it: clicking into the conversation would
// otherwise frame the whole of it.
function MessageScrollerViewport({
className,
...props
Expand All @@ -45,7 +47,7 @@ function MessageScrollerViewport({
data-slot="message-scroller-viewport"
data-scrollable-end={scrollable.end}
className={cn(
'size-full min-h-0 min-w-0 scroll-fade-b scrollbar-thin scrollbar-gutter-stable overflow-y-auto overscroll-contain contain-content data-autoscrolling:scrollbar-thumb-transparent data-autoscrolling:scrollbar-track-transparent data-pending-scroll:invisible',
'size-full min-h-0 min-w-0 outline-none scroll-fade-b scrollbar-thin scrollbar-gutter-stable overflow-y-auto overscroll-contain contain-content data-autoscrolling:scrollbar-thumb-transparent data-autoscrolling:scrollbar-track-transparent data-pending-scroll:invisible',
className,
)}
{...props}
Expand Down
Loading