Repository navigation
move chat's list rows as they come, go or change places - #285
Merged
Merged
Conversation
…ask opened from the conversation at once
…lick's own act drops can't leave the page unshown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat's list now animates rows with a new
useListMotionhook (FLIP-style transforms and opacity) instead of the CSS grid-row animation: a task opened, closed, pinned or unpinned, or an agent made, deleted or moved up, slides into place rather than jumping. Because only transform and opacity animate, the motion runs off the main thread and isn't held up while the newly opened page renders. A task opened from the conversation is now named in the header and shown under its agent immediately, before its chat loads.This also fixes a flaky chat-page test (also flaky on main). Any
use()call insideactmarks the render as having used a promise, so when that render didn't finish in time, the synchronousactaroundfireEvent.clickdropped the work. React kept a placeholder callback and never drew the page the link led to. Clicks that navigate are now wrapped in an awaitedact.Open workspace in Conductor