Repository navigation
[GH-9046] Expose constants in ClassesCollection - #36
Merged
Eric Silverberg (esilverberg) merged 1 commit intoSep 21, 2026
Merged
Eric Silverberg (esilverberg) merged 1 commit into
Eric Silverberg (esilverberg) merged 1 commit into
Conversation
Copilot started reviewing on behalf of
Eric Silverberg (esilverberg)
September 19, 2026 13:52
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation follows established collection patterns and has appropriate test coverage.
Review effort: Lite
Findings: None
What changed in this PR
Adds ClassesCollection#constants, matching existing collection aggregation APIs and covering it with an RSpec example.
Changes:
- Aggregates constants from all class declarations.
- Adds a type and value assertion for the new API.
| File | Description |
|---|---|
lib/rubyzen/collections/classes_collection.rb |
Implements constant aggregation. |
spec/collections/classes_collection_spec.rb |
Tests the new collection method. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Stelios Frantzeskakis (steliosfran)
approved these changes
Sep 21, 2026
Eric Silverberg (esilverberg)
deleted the
9046-expose-constants-in-classescollection
branch
September 21, 2026 19:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Checklist
bundle exec rakepasses locally (runs both the RSpec and Minitest suites)[GH-9046] Expose constants in ClassesCollection