Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246.
zonal_statspreviously converted the input window to a plain ndarray and constructed a new geometry/nodata mask, discarding the sourcenp.ma.MaskedArraymask. Masked pixels then contributed to count, sum, mean, and nodata/NaN counts. Preserve the source mask through boundless reads and combine it with the geometry and nodata masks.Validation:
git diff --checkpass.tests/test_io.pycollection could not run because the installedpyogrioDLL is blocked by local Windows application policy. The five syntheticboundless_arraychecks ran independently of the vector fixture. CI remains unverified until it runs upstream.Implemented and tested with Codex assistance; reviewed the patch and results before submission.