Repository navigation
test(e2e): measure content width only after the TOC transition ends - #1825
Merged
Merged
Conversation
"wide stays aligned next to the expanded TOC side panel" failed in CI on #1823 (3.7px) and #1824 (25px) without touching the viewer. The TOC pane and the subheader's reserved padding animate their width over 200ms, and the spec measured once right after the panel became visible, so content and header rows could be caught mid-animation. measureViewer now waits until no CSS transition is running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Flaky e2e test from #1821; failed in CI on #1823 and #1824 without either touching the page view.
What changed
e2e/tests/settings-content-width.spec.ts:measureViewerwaits until no CSS transition is running before it measures. The TOC pane and the subheader's reserved padding animate their width over 200ms (index.css), and the spec measured once right after the panel became visible, so the content and the header rows could be caught at different points of the animation (3.7px and 25px off). Only CSS transitions are awaited, so endless animations (spinners) can't block it. Test-only change.How I tested it
e2e/run.sh --grep "content width|wide" --repeat-each 10locally: 170/170 passed.npm run lintand Prettier ine2e,make verify-commits.Checklist
if featurebranches in shared code (rule 1)Behavior-Change:trailer (commit style)🤖 Generated with Claude Code