Repository navigation
Conversation
strconv.ParseBool accepts 1, 0, t and f, so the literal 1 compared equal to true and not to the number 1. Arazzo 1.0.1 defines only true and false as boolean literals. Fixes pb33f#690
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 313 313
Lines 39555 39558 +3
=========================================
+ Hits 39555 39558 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #690.
evaluateSimpleOperandusedstrconv.ParseBoolbeforestrconv.ParseInt.ParseBoolaccepts1and0, so$response.body#/revision == 1compared the number 1 withtrueand gavefalse.This change accepts only
trueandfalseas boolean literals, as Arazzo 1.0.1 Literals specifies. Other operands go to the number parsers as before.Tests
TestEvaluateCriterion_SimpleCondition_NumberAndBooleanLiteralscompares numbers and booleans from a response body. 6 of its 10 conditions fail before the change.go test ./arazzo/... ./datamodel/high/arazzo/... ./datamodel/low/arazzo/... .passes.AI disclosure
I used Claude Code, an AI coding assistant, to find the cause and to write this change and its test.