Repository navigation
fix: resolve relative refs against a root BaseURL - #688
Merged
Merged
Conversation
An empty base path made filepath.Abs resolve refs against the working directory, so refs failed and the local path was sent to the remote server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 313 313
Lines 39557 39560 +3
=========================================
+ Hits 39557 39560 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Coverage is measured per package, so the root package test did not count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a
BaseURLat a host root (for examplehttp://host), the base path is empty.filepath.Absthen fills in the local working directory, so a relative$refcan fail to resolve and the local path is sent to the remote server.This roots an empty base path at
/. Reproduced first with a failing test against a real HTTP server.Go version unchanged.
🤖 Generated with Claude Code