Repository navigation
fix(approve): sign off docs that link to each other in one call - #18
Merged
Merged
Conversation
approve gated each doc right after editing it. With the bergab check on, a doc linking to another doc still in review fails, so two docs that link to each other could never be signed off: each was refused while the other was still in review, also when both were named in the same call. Now all docs of one call are written first and then gated. A doc that fails is restored, and the remaining ones are gated again, since one of them may link to the restored doc. Writing first widens the window in which docs are accepted but not yet gated, so every doc that is written and not confirmed is restored when the run stops early (an exception or an interrupt). A doc named twice, under any spelling of its path, is handled once.
Owner
Author
Code review (claude-opus-5-5, effort high) and how it was handledThe review ran on the first version of the commit. Eight findings, unverified by the reviewer:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
km approvegated each doc right after editing it. With the gate's bergab check on, a served doc may not link to a doc still inreview. Two docs that link to each other could therefore never be signed off: each one was refused because the other was still in review, also when both were named in the same call. The only way out was to setstatusand the approval fields by hand, which the skill tells users not to do.Change
preparereturns aCandidate(NamedTuple) instead of a positional tuple.Tests
New cases in
tests/gate_smoke.sh, each checked against a mutant:ifinstead ofwhile)continueis removedAll smoke tests pass: gate 85, team 96, index 30, doctor 29, encoding 4.